Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: use CommandContext to cancel conduit process. #5636

Merged
merged 2 commits into from Aug 7, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Aug 3, 2023

Summary

I was noticing that the conduit process was not always being terminated. This makes the termination more reliable by:

  1. Using a CommandContext to do the heavy lifting.
  2. Setting a WaitDelay which should cause wait to timeout and trigger a Kill if a graceful shutdown takes too long.

Also added a couple more lifecycle log messages.

@winder winder requested review from tzaffi and shiqizng August 3, 2023 19:16
@winder winder marked this pull request as ready for review August 3, 2023 19:16
@winder winder self-assigned this Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #5636 (dde3649) into master (8b19c62) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5636   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files         463      463           
  Lines       64476    64476           
=======================================
+ Hits        35432    35434    +2     
  Misses      26661    26661           
+ Partials     2383     2381    -2     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder merged commit 95e3504 into algorand:master Aug 7, 2023
18 of 20 checks passed
@winder winder deleted the will/blockgen-cf branch August 7, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants