Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger: Close the ledger at node shutdown #5668

Merged
merged 2 commits into from Aug 16, 2023

Conversation

algonautshant
Copy link
Contributor

The ledger is never closed. This closes the ledger when shutting down the node.

@algonautshant algonautshant self-assigned this Aug 15, 2023
@algonautshant algonautshant marked this pull request as ready for review August 15, 2023 20:43
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #5668 (06d9cba) into master (3425e85) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5668      +/-   ##
==========================================
+ Coverage   55.15%   55.17%   +0.02%     
==========================================
  Files         465      465              
  Lines       65024    65025       +1     
==========================================
+ Hits        35862    35877      +15     
+ Misses      26769    26759      -10     
+ Partials     2393     2389       -4     
Files Changed Coverage Δ
node/node.go 4.14% <0.00%> (-0.01%) ⬇️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bbroder-algo bbroder-algo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems pretty innocuous, although ledger.Close() does kick off a lot of previously unexecuted locks and waits. but closing releases a lot of resources and was probably part the original lifecycle design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants