AVM: Expose global fields to TEAL that return MBR for asset create/optin
#5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are actually returning the same internal constant, but this will allow people to write "future proof" smart contracts that care about the mbr incremenet for creating or opting into assets.
jannotti
changed the title
global fields to TEAL that return MBR for asset create/optinglobal fields to TEAL that return MBR for asset create/optin
Codecov Report
@@ Coverage Diff @@
## master #5680 +/- ##
==========================================
+ Coverage 55.16% 55.17% +0.01%
==========================================
Files 465 465
Lines 64971 64975 +4
==========================================
+ Hits 35840 35849 +9
Misses 26734 26734
+ Partials 2397 2392 -5
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahangsu
previously approved these changes
Aug 18, 2023
jasonpaulos
reviewed
Aug 18, 2023
jasonpaulos
approved these changes
Aug 18, 2023
ahangsu
approved these changes
Aug 18, 2023
bbroder-algo
pushed a commit
to bbroder-algo/go-algorand
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are actually returning the same internal constant, but this will allow people to write "future proof" smart contracts that care about the mbr increment for creating or opting into assets.
Extended the "usual" tests for new fields to make sure they only appear in v10 and not before.