perf: upgrade go-deadlock #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/go-deadlock-upgrade
branch
from
361dfdd
to
8bbb3c9
Compare
algorandskiy
force-pushed
the
pavel/go-deadlock-upgrade
branch
from
8bbb3c9
to
32e1b6f
Compare
winder
approved these changes
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #5760 +/- ##
==========================================
+ Coverage 54.59% 55.44% +0.85%
==========================================
Files 473 473
Lines 66682 66682
==========================================
+ Hits 36403 36973 +570
+ Misses 27751 27193 -558
+ Partials 2528 2516 -12 see 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jasonpaulos
approved these changes
Sep 27, 2023
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apply performance fix from algorand/go-deadlock#2
TL;DR: no noticeable TPS improvement but for sure better memory utilization.
Test Plan
Run s1s with
--numapp 10 --appprogops 200 --refresh 1800 --numaccounts 500 --quiet(the same as apps medium periodic).Master
Feature