New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Reorganize the crypto opcodes a bit to simplify incentive work #5787
Conversation
0f65051
to
82e9b6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #5787 +/- ##
==========================================
+ Coverage 55.55% 55.58% +0.03%
==========================================
Files 474 475 +1
Lines 66850 66850
==========================================
+ Hits 37138 37161 +23
+ Misses 27188 27180 -8
+ Partials 2524 2509 -15
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, I just have some minor questions/comments.
I also verified the new crypto.go
contains exactly the code removed from eval.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question about a newly added notrack
below
Improves type checking a bit, improves ease of unit tests for new opcodes, moves crypto into their own files, adds some coverage.