Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follower: update follower node error messages. #5797

Merged
merged 1 commit into from Oct 23, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Oct 23, 2023

Summary

The feature was renamed from sync to follower and this error message was not updated along with it.

There is a possibility that user code could be checking for this message, so this could be considered a breaking change. This error message also indicates a configuration issue, so error handling would be unable to resolve it.

My recommendation is to make the breaking change.

Test Plan

@winder winder self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #5797 (1cae0a7) into master (d4b4086) will increase coverage by 0.23%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #5797      +/-   ##
==========================================
+ Coverage   55.32%   55.56%   +0.23%     
==========================================
  Files         475      475              
  Lines       66850    66850              
==========================================
+ Hits        36988    37142     +154     
+ Misses      27341    27187     -154     
  Partials     2521     2521              
Files Coverage Δ
node/follower_node.go 45.16% <66.66%> (+3.22%) ⬆️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review October 23, 2023 13:37
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the added benefit of clarity here outweigh the potential risks

@winder winder merged commit 29072a0 into algorand:master Oct 23, 2023
18 of 19 checks passed
@winder winder deleted the will/sync-to-follower branch October 23, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants