Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: wait longer in TestTotalWeightChanges for larger nightly test network #5841

Merged
merged 1 commit into from Dec 7, 2023

Conversation

ohill
Copy link
Contributor

@ohill ohill commented Nov 21, 2023

Summary

During nightly / non-short runs, TestTotalWeightChanges uses a 7-node test network (compared to 3 nodes for PR commit short tests) and sometimes hits this 30s timeout when running in CI, this happens while nodes are first starting up and not yet finished coming to agreement on round 1. Provides a little more time for nodes to start up in a resource constrained nightly CI runner machine

Test Plan

Tests are unchanged except for length of timeout.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90b10d2) 55.81% compared to head (06ed556) 55.77%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5841      +/-   ##
==========================================
- Coverage   55.81%   55.77%   -0.05%     
==========================================
  Files         476      476              
  Lines       67138    67138              
==========================================
- Hits        37476    37448      -28     
- Misses      27141    27154      +13     
- Partials     2521     2536      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannotti jannotti merged commit 4291e53 into algorand:master Dec 7, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants