Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: participation key lifecycle. #5847

Merged
merged 5 commits into from Nov 30, 2023
Merged

docs: participation key lifecycle. #5847

merged 5 commits into from Nov 30, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Nov 28, 2023

Documentation about the lifecycle of participation keys.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3abe5c8) 55.83% compared to head (9326aa9) 55.82%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5847      +/-   ##
==========================================
- Coverage   55.83%   55.82%   -0.01%     
==========================================
  Files         477      477              
  Lines       67256    67256              
==========================================
- Hits        37552    37549       -3     
+ Misses      27171    27170       -1     
- Partials     2533     2537       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick notes on your draft, but looks great!

docs/participation_key_lifecycle.md Outdated Show resolved Hide resolved
docs/participation_key_lifecycle.md Outdated Show resolved Hide resolved
docs/participation_key_lifecycle.md Outdated Show resolved Hide resolved
docs/participation_key_lifecycle.md Outdated Show resolved Hide resolved
docs/participation_key_lifecycle.md Show resolved Hide resolved
docs/participation_key_lifecycle.md Show resolved Hide resolved
docs/participation_key_lifecycle.md Show resolved Hide resolved
docs/participation_key_lifecycle.md Outdated Show resolved Hide resolved
docs/participation_key_lifecycle.md Outdated Show resolved Hide resolved
docs/participation_key_lifecycle.md Show resolved Hide resolved
Co-authored-by: John Lee <john@onetechnical.com>
@winder winder marked this pull request as ready for review November 30, 2023 16:05
onetechnical
onetechnical previously approved these changes Nov 30, 2023
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
@winder winder merged commit ae133b8 into algorand:master Nov 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants