Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update testing to use current python SDK. #5861

Merged
merged 2 commits into from Dec 8, 2023

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Dec 8, 2023

Changed our pinning strategy to only care about major versions, as minor versions aren't supposed to break things, and updates can be useful. Don't want a PR here every time we go from 2.4.11 to 2.4.12.

Existing e2e sub tests are the only thing this affects.

Changed our pinning strategy to only care about major versions, as
minor versions aren't supposed to break things, and updates can be
useful. Don't want a PR here every time we go from 2.4.11 to 2.4.12.
@jannotti jannotti self-assigned this Dec 8, 2023
@jannotti jannotti marked this pull request as ready for review December 8, 2023 19:12
gmalouf
gmalouf previously approved these changes Dec 8, 2023
test/scripts/e2e.sh Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b28b145) 55.96% compared to head (4ec9c2e) 55.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5861      +/-   ##
==========================================
- Coverage   55.96%   55.94%   -0.02%     
==========================================
  Files         477      477              
  Lines       67400    67400              
==========================================
- Hits        37721    37708      -13     
- Misses      27128    27138      +10     
- Partials     2551     2554       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannotti jannotti requested a review from gmalouf December 8, 2023 20:11
@gmalouf gmalouf merged commit 4b872f2 into algorand:master Dec 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants