AVM: Require every global field to get tested #5864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
approved these changes
Dec 11, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5864 +/- ##
==========================================
- Coverage 55.96% 55.92% -0.05%
==========================================
Files 477 477
Lines 67400 67400
==========================================
- Hits 37721 37692 -29
- Misses 27128 27150 +22
- Partials 2551 2558 +7 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Dec 11, 2023
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for
global GenesisHashand a test to ensure such tests must be added when new globals are added.