Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txHandler: kick in ARL at 1/2 of a base backlog capacity #5873

Merged
merged 3 commits into from Dec 21, 2023

Conversation

algorandskiy
Copy link
Contributor

Summary

While checking ARL after deployment I found out ARL can be more aggressive. The original settings kicked in it at 1/2 of the adjusted to ERL capacity (defaults are 26k + 2.4k*20 = 74k, so it kicks in at 36k backlogged messages).
Logs showed these settings are fine for extreme traffic with full txn groups but not enough for high traffic where the backlog stays at ~20k messages. Given the fact 20k messages is kind of enough to make almost full blocks, we have not observed committed 20k txns per block during these time periods. So that most of these txns are junk and can be discarded earlier.

Test Plan

Adjusted unit test to ensure the new kick-in condition.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8f8ada5) 55.91% compared to head (5b3d29d) 55.98%.

Files Patch % Lines
data/txHandler.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5873      +/-   ##
==========================================
+ Coverage   55.91%   55.98%   +0.07%     
==========================================
  Files         477      477              
  Lines       67407    67408       +1     
==========================================
+ Hits        37689    37740      +51     
+ Misses      27157    27118      -39     
+ Partials     2561     2550      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy marked this pull request as ready for review December 21, 2023 16:28
@algorandskiy algorandskiy merged commit 55cbb7f into algorand:master Dec 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants