Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netgoal: Use --last-part-key-round when generating a goalnet template #5912

Merged
merged 1 commit into from Jan 26, 2024

Conversation

nullun
Copy link
Contributor

@nullun nullun commented Jan 20, 2024

Whenever I've generated a goalnet template using netgoal I have to manually modify the LastPartKeyRound value from 3000000 to something like 10000, depsite using the --last-part-key-round argument in the command.
Example:

netgoal generate -n 1 -R 0 -w 4 --last-part-key-round 10000 -t goalnet -r tmpnet -o tmpnet.json
goal network create -t tmpnet.json -n tmpnet --start -r tmpnet

This fix works in the same way generating a genesis template works. I've no idea how many people use this, but it's a nice quick QOL update for me.

@nullun nullun changed the title Set LastPartKeyRound when generating a goalnet template netgoal: Use --last-part-key-round when generating a goalnet template Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (877090b) 55.99% compared to head (4b54c45) 55.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5912      +/-   ##
==========================================
- Coverage   55.99%   55.97%   -0.03%     
==========================================
  Files         478      478              
  Lines       67602    67602              
==========================================
- Hits        37855    37838      -17     
- Misses      27187    27200      +13     
- Partials     2560     2564       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@algorandskiy algorandskiy merged commit b5927a6 into algorand:master Jan 26, 2024
18 of 20 checks passed
@nullun nullun deleted the netgoal-partkey branch January 27, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants