Archival Support: Remove configurable support for catching up from "archivers" #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for archiver catchup that utilized it.
…arying settings for the EnableGossipService flag.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5920 +/- ##
==========================================
- Coverage 56.02% 55.94% -0.09%
==========================================
Files 478 478
Lines 67613 67561 -52
==========================================
- Hits 37878 37794 -84
- Misses 27176 27203 +27
- Partials 2559 2564 +5 ☔ View full report in Codecov by Sentry. |
…nd falling back/redirecting to them within the block service. Refactored blockservice redirect tests to primarily leverage 'getNextCustomFallbackEndpoint' for retrieving a peer list (empty by default.
gmalouf
changed the title
jannotti
reviewed
Jan 25, 2024
Co-authored-by: John Jannotti <jannotti@gmail.com>
jannotti
approved these changes
Jan 25, 2024
algorandskiy
approved these changes
Jan 25, 2024
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes configurable support for catching up from or (in the case of block serving) falling back to "archivers"; a concept that was never utilized on mainnet nor is currently on testnet. This fits with the larger effort to support first class non-archival relays and dedicated archival nodes for catchup/catchpoint purposes.
A concurrency issue was addressed around read/write access to
blockService.fallbackEndpoints.lastUsedalong the way.Test Plan
No longer relevant test scenarios are removed, a few cases were added in catchup service to reflect needing EnableGossipService set to be a relay, existing tests should otherwise pass.