Blocks: Bump min to save based on catchpoint support #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atchup from a recent catchpoint into account.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5927 +/- ##
==========================================
- Coverage 56.00% 55.95% -0.05%
==========================================
Files 478 478
Lines 67561 67569 +8
==========================================
- Hits 37835 37807 -28
- Misses 27174 27205 +31
- Partials 2552 2557 +5 ☔ View full report in Codecov by Sentry. |
jannotti
reviewed
Feb 2, 2024
jannotti
reviewed
Feb 2, 2024
…nCatchpointRoundsLookback.
jannotti
reviewed
Feb 3, 2024
algorandskiy
reviewed
Feb 5, 2024
…ections/cut test runtime down below 0.5 seconds.
algorandskiy
approved these changes
Feb 5, 2024
jannotti
approved these changes
Feb 5, 2024
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support minimum number of rounds saved that takes the being able to catchup from a recent catchpoint into account.
Test Plan
Added a new unit test that exercises the impact of enabling/disabling catchpoint support on ledger's
minToSavecalculation.