Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: fix package signing issues #5934

Merged
merged 24 commits into from Feb 13, 2024

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Feb 12, 2024

Summary

Issues in some of the pipelines was preventing a clean end to end build. This PR makes the following changes:

  • Fix issues in debian and rpm package building pipelines
  • Shift rpm signing to build instead of rpm repository update step
  • Explicitly enable ARM64 and disable ARM32
  • Cleanup of some parameters passed to build stages
  • Removed alphanet from some build processes

Test Plan

Manual testing around building and signing

@onetechnical onetechnical self-assigned this Feb 12, 2024
@onetechnical onetechnical marked this pull request as ready for review February 12, 2024 21:56
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1747aba) 55.23% compared to head (2ac8b2a) 55.95%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5934      +/-   ##
==========================================
+ Coverage   55.23%   55.95%   +0.72%     
==========================================
  Files         478      478              
  Lines       67569    67569              
==========================================
+ Hits        37319    37811     +492     
+ Misses      27660    27197     -463     
+ Partials     2590     2561      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants