Network: Archival node DNS Resolution #5940
Merged
+51
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ival Node peer requests now map to peers discovered from the archive dns entry (used to fallback to relays). Peer requests for 'archivers' are no longer supported.
…otstrap logic (re-uses pattern from dnsBootstrapId that is applied to relays).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5940 +/- ##
=======================================
Coverage 55.74% 55.75%
=======================================
Files 488 488
Lines 68103 68101 -2
=======================================
+ Hits 37966 37967 +1
+ Misses 27573 27564 -9
- Partials 2564 2570 +6 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Feb 23, 2024
jasonpaulos
approved these changes
Feb 23, 2024
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support resolving archival nodes from the archive dns entry. Phonebook queries for archival nodes have been updated to resolve to addresses discovered from the archive dns entry (these queries previously mapped to relay addresses).
Deduplication of addresses resolved from primary/secondary DNS bootstrap services for archival nodes is now supported as well.
Remaining mentions of 'archivers' were removed to avoid future confusion.
Test Plan
Existing tests were updated/should pass. Also ran algod manually to ensure proper DNS queries taking place.