Network: Penalize peer/class rankings when peer does not have catchpoint

[gmalouf]

Summary

Penalize peer/class rankings during catchpoint catchup initialization when they do not have a catchpoint. This is critical to ensure that the class based peer selector falls back to the next class of peers when too many peers in the first priority class do not have a catchpoint (in turn to prevent blocking the node from doing a fast catchup).

Test Plan

Reproduced catchup against older catchpoints on Betanet getting failing locally, then working properly once the ranking was included. Existing automated tests should all pass.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.73%. Comparing base (dd22cff) to head (b717438).

Files	Patch %	Lines
catchup/catchpointService.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5959      +/-   ##
==========================================
+ Coverage   55.71%   55.73%   +0.02%     
==========================================
  Files         489      489              
  Lines       68111    68112       +1     
==========================================
+ Hits        37946    37963      +17     
+ Misses      27590    27573      -17     
- Partials     2575     2576       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.