Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Revert "feat: add support to display mnemonic discreetly for algokey generate" #5974

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

onetechnical
Copy link
Contributor

Summary

Reverts #5886

As part of a review of our external dependencies (in the wake of the xz incident), we decided the sensitivity of this data was not worth the risk inherent in post-processing it with this external library.

Testing

Verify algokey behavior works as expected.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.02%. Comparing base (0e7087b) to head (48497a3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5974      +/-   ##
==========================================
+ Coverage   55.73%   56.02%   +0.29%     
==========================================
  Files         490      481       -9     
  Lines       68125    67646     -479     
==========================================
- Hits        37967    37901      -66     
+ Misses      27586    27182     -404     
+ Partials     2572     2563       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnalanwoods
Copy link

Agreed. It's too sensitive.

@onetechnical onetechnical merged commit dfd95ff into master Apr 4, 2024
21 checks passed
@onetechnical onetechnical deleted the revert-5886-feat/display-discreetly branch April 4, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants