Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduit: Pass data dir to plugin config. #1357

Merged
merged 7 commits into from Dec 6, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Nov 30, 2022

Summary

Pass a data directory to plugins so that path arguments can be optional.

Test Plan

New unit tests.

@winder winder self-assigned this Nov 30, 2022
@winder winder added the Enhancement New feature or request label Dec 5, 2022
@winder winder changed the title Pass data dir to plugin config. conduit: Pass data dir to plugin config. Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1357 (b43b0da) into develop (7d7f31e) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #1357      +/-   ##
===========================================
- Coverage    62.78%   62.71%   -0.07%     
===========================================
  Files           76       77       +1     
  Lines        10377    10374       -3     
===========================================
- Hits          6515     6506       -9     
- Misses        3303     3308       +5     
- Partials       559      560       +1     
Impacted Files Coverage Δ
...ugins/processors/blockprocessor/block_processor.go 67.21% <0.00%> (+0.82%) ⬆️
conduit/plugins/processors/noop/noop_processor.go 57.89% <0.00%> (ø)
...ins/processors/filterprocessor/filter_processor.go 80.55% <40.00%> (-2.12%) ⬇️
conduit/plugins/exporters/noop/noop_exporter.go 77.27% <66.66%> (ø)
conduit/pipeline/pipeline.go 64.63% <69.23%> (-1.04%) ⬇️
conduit/plugins/config.go 100.00% <100.00%> (ø)
...duit/plugins/exporters/example/example_exporter.go 88.88% <100.00%> (ø)
...duit/plugins/exporters/filewriter/file_exporter.go 75.47% <100.00%> (-7.87%) ⬇️
...lugins/exporters/postgresql/postgresql_exporter.go 80.23% <100.00%> (ø)
conduit/plugins/importers/algod/algod_importer.go 77.01% <100.00%> (-1.02%) ⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder requested a review from shiqizng December 5, 2022 21:55
@winder winder marked this pull request as ready for review December 5, 2022 21:55
Copy link
Contributor

@mciccarello mciccarello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't see anything that directly conflicts with what I've done with the plugin config strings. However be aware I've changed how they are indented slightly to make it work with conduit init, and I am dependent on that particular format (which I'm not super happy about, but will take time to generalize)

@winder winder merged commit 9267008 into algorand:develop Dec 6, 2022
@winder winder deleted the will/plugin-data-dir branch December 6, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants