Support StateProof keys. #778
Conversation
There was a problem hiding this comment.
Generally looks good to me, though I can't give great feedback on some indexer-specific testing changes, like if it's ok to modify createTxn.
Also note that the go-algorand submodule was updated to use the branch from algorand/go-algorand#2990, so probably that needs to be merged and the submodule changed back to master (or stable?) before this PR should be merged
compact cert will be part of a different release. I was told to include keyreg changes only. |
| @@ -571,47 +582,34 @@ func TestFetchAccountsRewindRoundTooLarge(t *testing.T) { | |||
| func createTxn(t *testing.T, target string) []byte { | |||
There was a problem hiding this comment.
Could you add a line like defer assert.Fail("this method should only be used for generating test inputs.") so that we don't accidentally use this function in real tests?
There was a problem hiding this comment.
Adding this thing makes the CI fail.
do you have a different suggestion for that?
There was a problem hiding this comment.
Why is this function being called? It looks like a helper for adding a new test.
There was a problem hiding this comment.
The idea is to keep the code that generates the test_resource.
I couldn't find more functions like this. Do you think it is worth keeping? (not as a Test function?)
There was a problem hiding this comment.
Yes, it is worth keeping.
addNewTest above is set to false, so this function is never called. It should never be called in a finished test which is why I suggested putting assert.Fail in here.
api/handlers_e2e_test.go
Outdated
| @@ -300,6 +302,97 @@ func TestPagingRootTxnDeduplication(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestTransactionHandler(t *testing.T) { | |||
There was a problem hiding this comment.
Could you change this test name to reflect that you're testing the keyreg transaction?
| var stateProofPK merklekeystore.Verifier | ||
| stateProofPK[0] = 1 | ||
|
|
||
| txn := transactions.SignedTxnWithAD{ |
There was a problem hiding this comment.
You updated MakeSimpleKeyregOnlineTxn but it doesn't seem to be used anywhere. You could repurpose it for this test, or remove it.
Codecov Report
@@ Coverage Diff @@
## develop #778 +/- ##
===========================================
+ Coverage 58.85% 59.02% +0.17%
===========================================
Files 37 37
Lines 4421 4425 +4
===========================================
+ Hits 2602 2612 +10
+ Misses 1510 1499 -11
- Partials 309 314 +5
Continue to review full report at Codecov.
|
idb/postgres/postgres.go
Outdated
| @@ -1200,6 +1202,10 @@ func (db *IndexerDb) yieldAccountsThread(req *getAccountsRequest) { | |||
| if hasVote { | |||
| part.VoteParticipationKey = ad.VoteID[:] | |||
| } | |||
| if hasStateProofkey { | |||
| sprfkey := ad.StateProofID[:] | |||
There was a problem hiding this comment.
to be safe, I would explicitly allocate new memory with new()
There was a problem hiding this comment.
Thanks, replaced this with our byteSlicePtr helper.
Summary
Add new field, StateProofKey, to key reg txn fields and account participation. Accounts data written to postgres is also updated accordingly to include the additional field.
Test Plan
Add new unit and e2e tests for api handler to validate that StateProofKey is returned correctly in response.