Add startup check to verify existing DB data matches the algod network.

[shiqizng]

Summary

Write and check genesis hash during db load genesis.

Test Plan

Add a test to postgres_integration_test

[codecov-commenter]

Codecov Report

Merging #833 (2b8d1f3) into develop (59e181f) will increase coverage by 0.04%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##           develop     #833      +/-   ##
===========================================
+ Coverage    59.17%   59.22%   +0.04%     
===========================================
  Files           32       32              
  Lines         4108     4137      +29     
===========================================
+ Hits          2431     2450      +19     
- Misses        1379     1384       +5     
- Partials       298      303       +5     

Impacted Files	Coverage Δ
idb/postgres/postgres.go	48.71% <58.33%> (+0.26%)	⬆️
idb/postgres/internal/encoding/encoding.go	75.56% <66.66%> (-0.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e181f...2b8d1f3. Read the comment docs.

[tolikzinovyev]

Is network ID enough? There might be some other parameters. Why not use the genesis hash?

[shiqizng]

Is network ID enough? There might be some other parameters. Why not use the genesis hash?

genesis hash isn't in bookkeeping.Genesis struct and so the hash is not available in LoadGenesis(genesis bookkeeping.Genesis). Maybe it's better to use Genesis.ID()?

// ID is the effective Genesis identifier - the combination
// of the network and the ledger schema version
func (genesis Genesis) ID() string {
	return string(genesis.Network) + "-" + genesis.SchemaID
}

[tolikzinovyev]

Is network ID enough? There might be some other parameters. Why not use the genesis hash?

genesis hash isn't in bookkeeping.Genesis struct and so the hash is not available in LoadGenesis(genesis bookkeeping.Genesis). Maybe it's better to use Genesis.ID()?

// ID is the effective Genesis identifier - the combination
// of the network and the ledger schema version
func (genesis Genesis) ID() string {
	return string(genesis.Network) + "-" + genesis.SchemaID
}

Seems like there is infrastructure for hashing bookkeeping.Genesis. https://github.com/algorand/go-algorand/blob/master/data/bookkeeping/genesis.go#L121 I just don't know how to invoke it.

[shiqizng]

Is network ID enough? There might be some other parameters. Why not use the genesis hash?

genesis hash isn't in bookkeeping.Genesis struct and so the hash is not available in LoadGenesis(genesis bookkeeping.Genesis). Maybe it's better to use Genesis.ID()?

// ID is the effective Genesis identifier - the combination
// of the network and the ledger schema version
func (genesis Genesis) ID() string {
	return string(genesis.Network) + "-" + genesis.SchemaID
}

Seems like there is infrastructure for hashing bookkeeping.Genesis. https://github.com/algorand/go-algorand/blob/master/data/bookkeeping/genesis.go#L121 I just don't know how to invoke it.

I changed the check to use genesis hash. I removed network ID check since the hash includes the ID also.

[tolikzinovyev]

LGTM