Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests for browser #211

Closed
jasonpaulos opened this issue Sep 21, 2020 · 0 comments · Fixed by #228
Closed

Run tests for browser #211

jasonpaulos opened this issue Sep 21, 2020 · 0 comments · Fixed by #228
Assignees
@jasonpaulos
Labels
FDE
Milestone
Sprint 11

Comments

@jasonpaulos
Copy link
Member

jasonpaulos commented Sep 21, 2020 •
edited

#209 is a bug where code for requesting data from some endpoints failed to return anything when ran in a web browser, but they worked fine in Node. To stop issues like this from happening, we should run the SDK tests in a browser context as well.

Cucumber and webdriver: https://cucumber.io/docs/guides/browser-automation/
@jasonpaulos jasonpaulos self-assigned this Sep 29, 2020
@ian-algorand ian-algorand added this to the Sprint 10 milestone Oct 1, 2020
@jasonpaulos jasonpaulos mentioned this issue Oct 5, 2020
Merged
@ian-algorand ian-algorand modified the milestones: Sprint 10, Sprint 11 Oct 15, 2020
bricerisingalgorand pushed a commit to bricerisingalgorand/js-algorand-sdk that referenced this issue Jul 20, 2021
@danmurphy1217
Solve Issue algorand#169: Merge Request headers in algod.py (algora…
6e2ac42 
…nd#211)

* add utility func for building headers for an AlgodClient.algod_request function call, import typehints

* call new utility function in v2client.algod.py, update kwargs['headers'] and pass along updated headers to self.algod_request

* if no headers are passed from kwargs['headers'], use the values passed in additional_headers

* update docstrings for util.py build_headers_from function

* remove headers kwarg from return statements in v2client/algod.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonpaulos jasonpaulos

Labels
FDE
Projects
None yet
Milestone
Sprint 11
Development

Successfully merging a pull request may close this issue.

Run tests for browser algorand/js-algorand-sdk
2 participants
@jasonpaulos @ian-algorand