Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that fee will be bumped up to min if finalFee < minFee #231

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

EvanJRichard
Copy link
Contributor

Summary

When Transaction building is done, the Transaction class checks whether the final fee is below the protocol minimum fee. If it is, the class silently bumps the fee up to the minimum. This surprises user-devs. This PR proposes to add If the final calculated fee is lower than the protocol minimum fee, the fee will be increased to match the minimum. to all main.js functions involving the fee.

Testing

Docs-only change; leaning on automated testing.

See also

Closes #224

Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have this in the docs.

@EvanJRichard EvanJRichard merged commit 4add848 into develop Oct 15, 2020
@EvanJRichard EvanJRichard deleted the evan/document_possible_fee_change branch October 15, 2020 13:32
@jasonpaulos jasonpaulos mentioned this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't silently change the fee
2 participants