Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate API types using code generation #325

Merged
merged 9 commits into from
Apr 6, 2021
Merged

Conversation

jdtzmn
Copy link
Contributor

@jdtzmn jdtzmn commented Mar 25, 2021

This PR includes a code template for API types and generated response types for the algod and indexer APIs.

Closes #311.

@jdtzmn jdtzmn requested a review from jasonpaulos March 25, 2021 21:33
@jdtzmn jdtzmn force-pushed the jacob/code-generation branch 4 times, most recently from 657c4d4 to c0c2b8c Compare March 26, 2021 20:17
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good!

I noticed that the new generated types aren't used yet, but I think we can make a separate issue for that.

src/types/blockHeader.d.ts Outdated Show resolved Hide resolved
src/client/v2/algod/models/types.ts Outdated Show resolved Hide resolved
* Use union types for numbers and bigints
@jdtzmn jdtzmn merged commit dde1044 into develop Apr 6, 2021
@jdtzmn jdtzmn deleted the jacob/code-generation branch April 6, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use code generation to create API types
2 participants