Add freezeAccount encoding in _getDictForDisplay #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
changed the title
ahangsu
reviewed
Oct 26, 2021
ahangsu
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds encoding from an
Addresstype to an address string for thefreezeAccountfield for the_getDictForDisplay()function. Since this is a cosmetic change, I visually checked the output in the unit test (makeAssetFreezeTxn), but we can possibly add a check there if we want to be more stringent.In addition, this PR updates the
chromedriverpackage to version95so that it can build and pass chrome tests on the latest stable version of the browser.Closes #430