Add stateproof keyreg field #463
Conversation
| @@ -192,7 +195,8 @@ export function makeKeyRegistrationTxnWithSuggestedParams( | |||
| voteKeyDilution: any, | |||
| suggestedParams: any, | |||
| rekeyTo?: any, | |||
| nonParticipation = false | |||
| nonParticipation = false, | |||
There was a problem hiding this comment.
nit: does this need to have a default value? it looks like that value is always set in the other constructors.
There was a problem hiding this comment.
This default value has runtime implications (i.e. JS will fill in false if no value is provided when the function is called) while the other definitions are purely for static type analysis
| @@ -206,6 +210,7 @@ export function makeKeyRegistrationTxnWithSuggestedParams( | |||
| type: TransactionType.keyreg, | |||
There was a problem hiding this comment.
you didn't make these changes, but do you know why type and reKeyTo are are labeled but the others are not?
There was a problem hiding this comment.
A label is not necessary if it's being set to a variable whose name is the same as the label. E.g. these are the same:
let a = 1;
let b = { a: a };
let c = { a }; // same as above| @@ -448,6 +489,7 @@ export class Transaction implements TransactionStorageStructure { | |||
| !txn.nonParticipation && | |||
| (txn.voteKey || | |||
There was a problem hiding this comment.
why is this check needed here. It's checking one of the fields is set?
There was a problem hiding this comment.
This is to make sure if any of the online keyreg fields are provided, then all must be provided
id-ms
force-pushed
the
stateproof2
branch
2 times, most recently
from
572e925
to
acea9e4
Compare
Add stateproof key field to keyreg transaction, in line with the changes from algorand/go-algorand#2990