-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wait for confirmation function #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition to the JS SDK 🎉
I'm also curious to whether this should be kept with algod
or transactions
(I believe the Python SDK binds this method to the latter).
await this.v2Client.statusAfterBlock(sp.firstRound + 2).do(); | ||
const fundingConfirmation = await this.acl.transactionById( | ||
fundingResponse.txId | ||
const info = await algosdk.waitForConfirmation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice -- also what is this.acl
? Is that the v1 client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's the v1 algod client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have general comments here. Just curious, why there are 2 alike implementation for WaitForConfirmation in JS-SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My bad, I originally forgot to delete the file in the algod client folder. |
* Added waitForConfirmation to v2 API * Renamed timeout to waitRounds * Move to waitForConfirmation function * Change eslint settings * Use in cucumber tests * Delete file from algod folder Co-authored-by: Damian Barabonkov <damianb@mit.edu>
Add wait for confirmation function for verifying transaction confirmation.