Fix wait for confirmation function #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
reviewed
Dec 7, 2021
src/wait.ts
Outdated
Comment on lines
38
to
47
| if (pendingInfo != null) { | ||
| if (pendingInfo['confirmed-round']) { | ||
| // Got the completed Transaction | ||
| return pendingInfo; | ||
| } | ||
|
|
||
| if (pendingInfo['pool-error']) { | ||
| // If there was a pool error, then the transaction has been rejected! | ||
| throw new Error(`Transaction Rejected: ${pendingInfo['pool-error']}`); | ||
| } |
There was a problem hiding this comment.
Move into the try block.
You check pendingInfo != null but above we check typeof status === 'undefined'. Which of these is more correct? Maybe checking for null isn't needed inside the try block.
There was a problem hiding this comment.
Good points, I'll modify this section
winder
approved these changes
Dec 7, 2021
This was referenced Dec 28, 2021
aldur
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Fix wait for confirmation function * Respond to feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issue with the wait for confirmation function:
pendingTransactionInformationthrows an error, that error should be ignored and the function should continue retrying ifwaitRoundsallows it.