Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ABI reference types and other improvements #482

Merged
merged 14 commits into from
Dec 27, 2021
Merged

Support ABI reference types and other improvements #482

merged 14 commits into from
Dec 27, 2021

Conversation

jasonpaulos
Copy link
Member

@jasonpaulos jasonpaulos commented Dec 9, 2021 •
edited
Loading

Closes #468, closes #483

@jasonpaulos jasonpaulos changed the title Support ABI reference types Support ABI reference types and other improvements Dec 9, 2021
@jasonpaulos jasonpaulos marked this pull request as ready for review December 21, 2021 19:40
algochoi
algochoi reviewed Dec 23, 2021
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new type checks! Overall looks good -- just had a few questions about resolving foreign objects in the composer.

src/composer.ts Show resolved Hide resolved
src/composer.ts Show resolved Hide resolved
ahangsu
ahangsu reviewed Dec 27, 2021
View reviewed changes
src/composer.ts Outdated Show resolved Hide resolved
ahangsu
ahangsu reviewed Dec 27, 2021
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks largely good to me, just some minor polishing here and there

@algochoi algochoi self-requested a review December 27, 2021 22:01
ahangsu
ahangsu approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonpaulos jasonpaulos merged commit 57c5645 into develop Dec 27, 2021
@jasonpaulos jasonpaulos deleted the abi-reference-types branch December 27, 2021 22:48
This was referenced Dec 28, 2021
Closed
Merged
@algobarb algobarb mentioned this pull request Jan 13, 2022
Merged
aldur pushed a commit that referenced this pull request Jan 20, 2022
@jasonpaulos @aldur
Support ABI reference types and other improvements (#482)
fd1347f 
* Support ABI reference types

* Use new `ABIContract.networks` field

* Document `populateForeignArray`

* Change `equal` to `equals`

* Temporarily change algorand-sdk-testing branch

* Fix firefox step

* Implement testing support for multiple methods in one atomic group

* Support ABI app creation & update

* Only check last log for return value

* Add description fields for Interface and Contract

* Fix return bug

* Set status to submitted during execution

* Switch back to master branch of cucumber repo

* Remove magic constants 15 and 14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

@ahangsu ahangsu ahangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ABI changes Support foreign objects as ABI arguments
3 participants
@jasonpaulos @algochoi @ahangsu