Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement C2C tests #498

Merged
merged 21 commits into from
Feb 9, 2022
Merged

Implement C2C tests #498

merged 21 commits into from
Feb 9, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Jan 15, 2022 •
edited
Loading

  • Add pendingTransactionInformation field to ABI methodResult
  • Implement all c2c.feature tests
  • Implement new test in applications.verified
  • Implement new test in compile.feature
  • Deprecate template tests - related PR here and related issue: Remove Template Feature Related Cucumber Tests #494
  • Revert branch change in run_docker.sh

Closes #487 #494

tzaffi
tzaffi approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking question.

LGTM

@algochoi algochoi linked an issue Jan 21, 2022 that may be closed by this pull request
Remove Template Feature Related Cucumber Tests #494
Closed
jasonpaulos
jasonpaulos requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few small but important comments

src/composer.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
@algochoi algochoi merged commit 926eed5 into develop Feb 9, 2022
This was referenced Feb 15, 2022
Closed
Merged
@onetechnical onetechnical mentioned this pull request Mar 7, 2022
Merged
@algochoi algochoi deleted the algochoi/c2c-testing branch April 28, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzaffi tzaffi tzaffi approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@ahangsu ahangsu Awaiting requested review from ahangsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Template Feature Related Cucumber Tests C2C feature testing and implementation
3 participants
@algochoi @tzaffi @jasonpaulos