Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FromObject parameter IntelliSense human readable #528

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Make FromObject parameter IntelliSense human readable #528

merged 2 commits into from
Feb 28, 2022

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Feb 27, 2022

Currently, the IntelliSense for FromObject transaction functions are not human readable:

image

This PR adds an Expand type that expands these types for IntelliSense:

image

As confirmed by the mocha tests, functionality is preserved, this is merely a change for improved IntelliSense.

jasonpaulos
jasonpaulos approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! This improves the generates docs immensely as well

@jasonpaulos jasonpaulos merged commit 82c7c4c into algorand:develop Feb 28, 2022
@onetechnical onetechnical mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joe-p @jasonpaulos