adding getMethodByName function to Contract and Interface #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnjamin
force-pushed
the
get-method-by-name
branch
from
028a4ae
to
824c750
Compare
algochoi
reviewed
Jun 13, 2022
barnjamin
force-pushed
the
get-method-by-name
branch
from
e8c285f
to
a80f3a3
Compare
jasonpaulos
reviewed
Jun 16, 2022
Comment on lines
+39
to
+40
| .setPreference('remote.active-protocols', 1) // Sets protocol to only WebDriver BiDi | ||
| .setPreference('network.http.network-changed.timeout', 30) // In Docker tests this apparently matters |
There was a problem hiding this comment.
Interesting, I'd expect setting remote.active-protocols to 2 (CDP) to be the solution here, since in Firefox 101 they changed the default from 2 to 3 (1|2).
Also, for network.http.network-changed.timeout, have you tried more values, or just 30?
There was a problem hiding this comment.
to be fair 1 was the first one I tried, something about the combination is tripping us.
I did not try more settings for timeout, 30s seemed sufficient, the default is 5
jasonpaulos
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Looks good! Thanks again for all the debugging work related to Firefox.
Once @algochoi agrees, this looks good to merge, and I hope this will be the last of the flaky Firefox tests 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.