Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: Update Chromedriver version and CI orb #802

Merged
merged 10 commits into from
Jul 20, 2023
Merged

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Jul 20, 2023

Chromedriver v115+ now ships with Chrome. npm's chromedriver does support this from v114 and onwards.

Also updates the CircleCI browser-tools orb that fixes a Chrome v115+ issue: CircleCI-Public/browser-tools-orb#81

Fixes CI failures on chrome.

@algochoi algochoi changed the title Update Chromedriver link 115>= Update Chromedriver link >=115 Jul 20, 2023
@algochoi algochoi changed the title Update Chromedriver link >=115 CI: Update Chromedriver link >=115 Jul 20, 2023
@algochoi algochoi changed the title CI: Update Chromedriver link >=115 CICD: Update Chromedriver link >=115 Jul 20, 2023
@algochoi algochoi changed the title CICD: Update Chromedriver link >=115 CICD: Update Chromedriver link Jul 20, 2023
@algochoi algochoi changed the title CICD: Update Chromedriver link CICD: Update Chromedriver version and CI orb Jul 20, 2023
@algochoi algochoi requested a review from a team July 20, 2023 15:43
@algochoi algochoi marked this pull request as ready for review July 20, 2023 15:43
@algochoi algochoi requested a review from a team as a code owner July 20, 2023 15:43
@algochoi algochoi requested review from excalq and algobarb July 20, 2023 15:43
@algochoi algochoi merged commit 4e1073d into develop Jul 20, 2023
7 checks passed
@algochoi algochoi deleted the update-chromedriver branch July 20, 2023 17:48
algochoi added a commit that referenced this pull request Jul 20, 2023
* Update Chromedriver link 115>=

* Use puppeteer to download latest stable chromedriver

* Update circle ci browser tools orb

* Don't manually install chromedriver

* Pin chromedriver version

* Remove comment

* Revert to 114

* Update selenium

* Test

* Update chromedriver 114
joe-p pushed a commit to joe-p/js-algorand-sdk that referenced this pull request Apr 11, 2024
* Update Chromedriver link 115>=

* Use puppeteer to download latest stable chromedriver

* Update circle ci browser tools orb

* Don't manually install chromedriver

* Pin chromedriver version

* Remove comment

* Revert to 114

* Update selenium

* Test

* Update chromedriver 114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants