-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug-fix: Pass verbosity through to testing harness #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Aug 23, 2022
tzaffi
commented
Aug 23, 2022
tzaffi
changed the title
Bug: channel = source isn't sticking in Circle
Bug-fix: Pass verbosity through to testing harness
Aug 23, 2022
tzaffi
commented
Aug 23, 2022
ahangsu
reviewed
Aug 23, 2022
…rand-sdk into bugfix-channel-v-source
tzaffi
commented
Aug 23, 2022
ahangsu
approved these changes
Aug 23, 2022
ahangsu
added a commit
that referenced
this pull request
Sep 2, 2022
* add check to desc so we dont output null if undefined (#368) * Bumped version to v1.16.1 * Enhancement: Trim the indexer images and use the sandbox instead of custom dockers (#367) Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * Bug-fix: Pass verbosity through to testing harness (#373) * Enhancement: Add State Proof support (#370) * add stateproof support * Enhancement: Deprecating use of langspec (#371) * Bumped version to v1.17.0 * Update README.md Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Mergeback: Release v1.17.0b1 (#378) * Bumped version * Update README.md * bumped version to v1.17.0 Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: shiqizng <80276844+shiqizng@users.noreply.github.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Jack <87339414+algojack@users.noreply.github.com> Co-authored-by: Lucky Baar <lucky.baar@algorand.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up from the companion SDK Testing Bugfix PR, we're going to pass through verbosity to the harness script via a new
-v
flag.For further context: here is what SDK Testing Bugfix PR says:
Testing
We can see that: