Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fix: Pass verbosity through to testing harness #373

Merged
merged 10 commits into from
Aug 23, 2022

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Aug 23, 2022

Summary

Following up from the companion SDK Testing Bugfix PR, we're going to pass through verbosity to the harness script via a new -v flag.

For further context: here is what SDK Testing Bugfix PR says:

The sandbox is always defaulting to release and the generated config.harness isn't sticking because the verbose flag is provided in the wrong order.

Additionally, after refactoring the SDK Sandboxization PR's to no longer overwrite .env, there is no way to pass through the verbosity, except by overwriting. The PR re-enables passing through by also reading VERBOSE_HARNESS as a flag (either -v or --verbose).

Testing

We can see that:

@tzaffi tzaffi marked this pull request as draft August 23, 2022 13:26
.test-env Outdated Show resolved Hide resolved
.test-env Outdated Show resolved Hide resolved
@tzaffi tzaffi added the Bug-Fix label Aug 23, 2022
@tzaffi tzaffi changed the title Bug: channel = source isn't sticking in Circle Bug-fix: Pass verbosity through to testing harness Aug 23, 2022
@tzaffi tzaffi marked this pull request as ready for review August 23, 2022 16:08
test-harness.sh Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tzaffi tzaffi merged commit 9f49624 into develop Aug 23, 2022
@tzaffi tzaffi deleted the bugfix-channel-v-source branch August 23, 2022 20:41
ahangsu added a commit that referenced this pull request Sep 2, 2022
* add check to desc so we dont output null if undefined (#368)

* Bumped version to v1.16.1

* Enhancement: Trim the indexer images and use the sandbox instead of custom dockers (#367)

Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* Bug-fix: Pass verbosity through to testing harness (#373)

* Enhancement: Add State Proof support (#370)

* add stateproof support

* Enhancement: Deprecating use of langspec  (#371)

* Bumped version to v1.17.0

* Update README.md

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Mergeback: Release v1.17.0b1 (#378)

* Bumped version
* Update README.md

* bumped version to v1.17.0

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Co-authored-by: shiqizng <80276844+shiqizng@users.noreply.github.com>
Co-authored-by: Jack Smith <jack.smith@algorand.com>
Co-authored-by: Jack <87339414+algojack@users.noreply.github.com>
Co-authored-by: Lucky Baar <lucky.baar@algorand.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants