Decoding: Fix roundtrip encode/decode tests for transactions #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
algochoi
commented
Nov 8, 2022
algochoi
changed the title
jasonpaulos
approved these changes
Nov 8, 2022
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the
StateSchemafield,accountsfield andon_completefields are decoded. In addition, it makes a change to acceptBoxReferencesin addition to a list of app IDs and box names intranslate_box_reference()(in the former case, no translation will be done).Related to algorand/algorand-sdk-testing#248