Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Migrate v1 algod usage to v2 algod #403

Merged
merged 4 commits into from Dec 2, 2022
Merged

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Dec 1, 2022

This PR changes the examples to use the v2client instead of v1 algod.

As a sanity check, ran the examples on my local machine.

@algochoi algochoi changed the title Migrate examples v2 examples: Migrate v1 algod usage to v2 algod Dec 1, 2022
@algochoi algochoi marked this pull request as ready for review December 1, 2022 19:27
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algochoi Thanks for making updates here - I spot checked several examples to confirm successful execution.

As discussed out-of-band, I think a more in-depth treatment of examples is out-of-scope to the PR and the as is PR is an improvement.

@algochoi algochoi merged commit af81001 into develop Dec 2, 2022
@algochoi algochoi deleted the migrate-examples-v2 branch December 8, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants