Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Breaking changes from v1 to v2.0.0 #415

Merged
merged 12 commits into from Dec 15, 2022
Merged

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Dec 6, 2022

This PR contains all (breaking) changes to be made for v1 to v2.0.0 SDK, epic here: #384

@michaeldiamant michaeldiamant marked this pull request as draft December 7, 2022 15:58
michaeldiamant and others added 2 commits December 15, 2022 09:11
…ts (#423)

* make logicsig hidden

* wording

* use LogicSigAccount

* Update CHANGELOG.md wording

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* change usage of logicsig in tests

* more comments

* remove changelog

* Update algosdk/transaction.py

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
@michaeldiamant michaeldiamant marked this pull request as ready for review December 15, 2022 20:43
@michaeldiamant michaeldiamant changed the title Enhancement: Breaking changes from v1 to v2.0.0 Deprecation: Breaking changes from v1 to v2.0.0 Dec 15, 2022
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks complete to me based on comparison of commits to the associated ticket. I expect CHANGELOG.md will be refined prior to release, and is safe to merge as is.

@michaeldiamant michaeldiamant changed the title Deprecation: Breaking changes from v1 to v2.0.0 v2: Breaking changes from v1 to v2.0.0 Dec 15, 2022
@michaeldiamant michaeldiamant merged commit 2aa4b70 into develop Dec 15, 2022
@michaeldiamant michaeldiamant deleted the feature/v2.0.0-break branch December 15, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants