New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Type Friendly Exports #435
Conversation
.circleci/config.yml
Outdated
- run: make lint | ||
- run: make check-setup | ||
- run: make pytest-unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bringing these commands into the Makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly defining __all__
seems like a good practice. Strangely, I don't notice any PyLance errors on my VSCode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introduce PyTeal's fix for VsCode type exports issue
This approach was introduced into PyTeal by @barnjamin. I'm just bringing it into this repo.
Former VsCode Pylance error when importing
py-algorand-sdk
:Testing