ATC: Refactor Pending Transaction Information in ATC into try block #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
changed the title
| self, method: abi.Method, txid: str, txn: Dict[str, Any] | ||
| ) -> ABIResult: | ||
| tx_id = txid | ||
| raw_value = b"" |
There was a problem hiding this comment.
they are functionally the same, but I changed all instances of empty byte literals to bytes() just in case it helps for readability in 5e2d2b7
| tx_id = self.tx_ids[method_index] | ||
| result: ABIResult = ABIResult( | ||
| tx_id=tx_id, | ||
| raw_value=b"", |
| raw_value=b"", | ||
| return_value=None, | ||
| decode_error=None, | ||
| tx_info={}, |
There was a problem hiding this comment.
tx_info = txn_results[method_index]?
There was a problem hiding this comment.
good point! addressed in 5e2d2b7
jasonpaulos
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves back the pending_transaction_information call in the ATC into a try block. This PR also refactors the
parse_responsehelper method so individual ABI result are parsed at a time (instead of the entire group), and can report thedecode_errorat the transaction level. This also reduces the total number of pending tx info calls we potentially make, as we only need to call them for ABI Method calls in the transaction group.