Fix: improve SignedTransaction type signature for dryrun and send_transaction #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
reviewed
Mar 27, 2023
barnjamin
force-pushed
the
dryrun-type-fix
branch
from
1904c40
to
b442714
Compare
barnjamin
changed the title
algochoi
approved these changes
Mar 27, 2023
algochoi
reviewed
Mar 27, 2023
| @@ -307,13 +307,13 @@ def status_after_block( | |||
| return self.algod_request("GET", req, **kwargs) | |||
|
|
|||
| def send_transaction( | |||
| self, txn: "transaction.Transaction", **kwargs: Any | |||
| self, txn: "transaction.GenericSignedTransaction", **kwargs: Any | |||
There was a problem hiding this comment.
nit: do we still need the quotes?
There was a problem hiding this comment.
It failed CI the first time with a message about partially initialized module transaction, didnt dig deep but quoting fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type parameter of GenericSignedTransaction to a couple places that had explicitly listed SignedTransaction types