Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: Ignore formatting commits in git blame #485

Merged
merged 5 commits into from Jun 26, 2023

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented May 17, 2023

Adds a .git-blame-ignore-revs to exclude formatting commits in the git history. This makes it easier to trace the git blame from source code. To enable locally, you may have to edit your Git settings: git config blame.ignoreRevsFile .git-blame-ignore-revs.

Visually confirmed in the Github blame viewer on this branch - there are some occasional lines that slip through, but I think it's a problem with the UI.

.git-blame-ignore-revs Outdated Show resolved Hide resolved
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super addition!

Made an ignoreable suggestion

@algochoi algochoi marked this pull request as ready for review June 16, 2023 13:30
@algochoi algochoi requested a review from a team as a code owner June 23, 2023 18:10
@algochoi algochoi requested review from excalq and algobarb June 23, 2023 18:10
@algochoi
Copy link
Contributor Author

Needed to update the ubuntu image to make sure CI builds pass - related to algorand/indexer#1545

@@ -33,7 +33,7 @@ jobs:
python-version:
type: string
machine:
image: "ubuntu-2004:202104-01"
image: "ubuntu-2204:2022.04.2"
Copy link
Contributor

@excalq excalq Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warty Warthog calling! 🐖

@algochoi algochoi merged commit 2ed7ab9 into develop Jun 26, 2023
12 checks passed
@algochoi algochoi deleted the ignore-formatting-blame branch June 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants