Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply black formatter #100

Merged
merged 5 commits into from
Aug 19, 2021
Merged

apply black formatter #100

merged 5 commits into from
Aug 19, 2021

Conversation

shiqizng
Copy link
Contributor

No description provided.

algochoi
algochoi reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change -- I think we also need to add black into the requirements.txt as well, and add a check: black --check . to the scripts section in the travis yml file.

e.g. algorand/py-algorand-sdk@6627bd6

@algochoi
Copy link
Contributor

Looks good to me 👍 . I'm not sure how this might affect Jason's commits/conflicts, so I will wait on his approval.

jasonpaulos
jasonpaulos approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for making this 👏

I have to rebase my changes on master anyway, so this is good to merge whenever you're ready.

pyteal/ir/ops.py Outdated
gaids = OpType("gaids", Mode.Application, 4)
callsub = OpType("callsub", Mode.Signature | Mode.Application, 4)
retsub = OpType("retsub", Mode.Signature | Mode.Application, 4)
err = OpType("err", Mode.Signature | Mode.Application, 2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me sad but I suppose there's no way to preserve the special spacing here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this: https://stackoverflow.com/questions/58584413/black-formatter-ignore-specific-multi-line-code ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The special formatting can stay. Thanks to @ahangsu.

@shiqizng shiqizng merged commit 4e8ab3f into master Aug 19, 2021
@jasonpaulos jasonpaulos mentioned this pull request Aug 31, 2021
Merged
@ahangsu ahangsu deleted the formatting branch April 14, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi left review comments

@ahangsu ahangsu ahangsu left review comments

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shiqizng @algochoi @jasonpaulos @ahangsu