Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword account and asset Transaction field references #295

Merged

Conversation

michaeldiamant
Copy link
Contributor

Rewords account and asset Transaction field references to hopefully make the intent clearer based on feedback from @algoanne.

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I am biased toward specifying that these are foreign assets and foreign applications, as per go-algorand docs in addition to these changes.

@algoanne
Copy link

algoanne commented Apr 25, 2022

@algochoi there's definitely some inconsistency across the documentations when referring to these and it is confusing, but would probably require more concerted effort to reach consistency in all the places. This smaller change at least fixes an instance that I found particularly misleading since "application accounts" can have a distinct meaning.

@michaeldiamant
Copy link
Contributor Author

Looks good, although I am biased toward specifying that these are foreign assets and foreign applications, as per go-algorand docs in addition to these changes.

I briefly spoke with @algochoi and agreed that we can leave as is for the PR because array of foreign accounts may also cause some confusion. Though we both agree there's room for improvement beyond the PR.

@michaeldiamant michaeldiamant merged commit 7db0d62 into algorand:master Apr 25, 2022
@michaeldiamant michaeldiamant deleted the transaction_field_verbiage branch April 25, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants