Fix If type bug
#329
Merged
Fix If type bug
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
commented
May 6, 2022
| @@ -37,7 +37,7 @@ def __test_single_conditional( | |||
| ifExpr = ( | |||
| pt.If(expr.output_slots[1].load()) | |||
| .Then(expr.output_slots[0].load()) | |||
| .Else(pt.Bytes("None")) | |||
| .Else(pt.App.globalGet(pt.Bytes("None"))) | |||
There was a problem hiding this comment.
This unit test was previously passing despite its then and else branches returning different types for some iterations.
To fix it, I've made the else branch return App.globalGet, which is a TealType.any, so it will be correct for all then branches unless the then branch is TealType.none.
There was a problem hiding this comment.
I see. I believe @algoidurovic wrote this test originally, so I'm curious if he has any thoughts about changing this test.
ahangsu
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTeal
Ifstatements have the following rules:TealType.TealType.none, since in this case the else branch is essentiallySeq()(a noop expression that returns nothing).These rules are properly enforced for the original
Ifsyntax (If(<condition>, <then>, <else>)), but the new syntax (If(<condition>).Then(<then>).Else(<else>)) unfortunately does not enforce these rules. This PR fixes that.