Fix base32 validation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, After checking the reference link to '6. Base 32 Encoding', 'Table 3: The Base 32 Alphabet' has from 2-7 and not from 2-9. Cheers,
Adding more details to RegEx
This regex will validate bettter if input message is really a Base32 encoded message.
|
|
|
Hi @Ursify, thanks for catching this! TEAL actually supports base32 with padding and without padding, so I've made a modification to support both schemes and added some tests. Once you sign the CLA I can approve this PR. |
jasonpaulos
added a commit
that referenced
this pull request
Mar 1, 2021
* Valid_Base32 Error Hi, After checking the reference link to '6. Base 32 Encoding', 'Table 3: The Base 32 Alphabet' has from 2-7 and not from 2-9. Cheers, * valid_base32 updates Adding more details to RegEx * Regex in Base32 This regex will validate bettter if input message is really a Base32 encoded message. * Add tests & support base32 no padding Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jason, Algorand Team.
Please review below regex update, I hope is fine and can pass your tests. Also, let me know if I need to point my pull request to codegen-test instead of master. This is my first pull request to a crypto project.
Cheers,
Ursify