Base 32 Pattern Check #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BASE 32 works in groups of 8 Characters. Valid Final 8 Characters(with / without padding): CC====== CC CCCC==== CCCC CCCCC=== CCCCC CCCCCCC= CCCCCCC CCCCCCCC Invalid Final 8 Characters(with / without padding): C======= C CCCCCC== CCCCCC Invalid 8 characters group should throw an error, since it won't be possible to uncoded them back.
|
Hi @Ursify, thanks for catching this too. I made a small change so that the regex accepts empty strings too and I've updated tests and an example which had invalid base32. Do you see any problems with the updated regex? |
Empty string was not raising TealInputError.
Sorry about that, first I understood that the issue was that empty strings were allowed. I rolled it back.
Hi @jasonpaulos , thanks for reviewing my PR. Your update is working fine. I run some test and all looks good. Cheers, |
jasonpaulos
approved these changes
Dec 5, 2020
jasonpaulos
added a commit
that referenced
this pull request
Mar 1, 2021
* Base 32 Pattern Check BASE 32 works in groups of 8 Characters. Valid Final 8 Characters(with / without padding): CC====== CC CCCC==== CCCC CCCCC=== CCCCC CCCCCCC= CCCCCCC CCCCCCCC Invalid Final 8 Characters(with / without padding): C======= C CCCCCC== CCCCCC Invalid 8 characters group should throw an error, since it won't be possible to uncoded them back. * Allow empty string & update tests * Add tests for incorrect padding * Fix on Empty String Empty string was not raising TealInputError. * Allowing Empty strings Sorry about that, first I understood that the issue was that empty strings were allowed. I rolled it back. Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jason, Algorand Team.
I hope below explanation makes sense.
BASE 32 works in groups of 8 Characters.
Valid Final 8 Characters(with / without padding):
CC======
CC
CCCC====
CCCC
CCCCC===
CCCCC
CCCCCCC=
CCCCCCC
CCCCCCCC
Invalid Final 8 Characters(with / without padding):
C=======
C
CCCCCC==
CCCCCC
Invalid 8 characters group should throw an error, since it won't be possible to uncoded them back.
Cheers,
Ursify