-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment as op #410
Comment as op #410
Conversation
426ab55
to
166d057
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also made a child PR which changes the Comment
implementation: #492
With this pr, adding comments on asserted expressions, parsing the error msg from algod out, then mapping it back to source teal I get the following output:
This is v close to what I think we'd want but the comment is a little far from the actual assert. I think the ideal output is that the comment is on the same line as (or just above) the assert so its easier to see what we're asserting and even provide a friendlier error message on assert. wdyt? Maybe a different Expr for assert w/ message is warranted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specific case of Assert
aside, I think this is a good addition by itself.
Note: probably we should get another approval before merging, as I also contributed to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lookin good, and I like the PR number, for that is my birthday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice, should also add an entry in CHANGELOG.md
, and consider a bit on #509
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
free approval bot says approve
Alternate impl to #407
for
Comment(Assert(Int(1)), "yep")