Add error for scratch slot load before store #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the compiler throw an error if a scratch slot is loaded before anything has been stored in it. This should make it safer to use
ScratchVarandMaybeValue.In order to make this type of error indicate where in the program an improperly used slot is, I had to change a few things. I modified
TealComponentand its subclasses to contain references to theExprthat created them, and I used thetracebackmodule to create formatted tracebacks every time anExpris created. These two changes allowed me to embed useful location information in the error that gets thrown.Closes #35.