Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: tupled app args with transaction type #577

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Fix: tupled app args with transaction type #577

merged 8 commits into from
Oct 21, 2022

Conversation

barnjamin
Copy link
Contributor

addresses #576

@barnjamin barnjamin requested review from michaeldiamant and ahangsu and removed request for michaeldiamant October 21, 2022 13:25
tonyfloatersu
tonyfloatersu reviewed Oct 21, 2022
View reviewed changes
Copy link

@tonyfloatersu tonyfloatersu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, it's also Hang, please consider add a line in CHANGELOG

ahangsu
ahangsu reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments to minimize the change, the move at this point seems reasonable to me.

Good to have the issue reproducing code in test case, with transaction being the last arg.

pyteal/ast/router.py Show resolved Hide resolved
pyteal/ast/router.py Outdated Show resolved Hide resolved
pyteal/ast/router.py Outdated Show resolved Hide resolved
pyteal/ast/router.py Outdated Show resolved Hide resolved
barnjamin and others added 4 commits October 21, 2022 12:35
@barnjamin @ahangsu
Update pyteal/ast/router.py
b134c51 
Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
@barnjamin @ahangsu
Update pyteal/ast/router.py
be84dfa 
Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
@barnjamin @ahangsu
Update pyteal/ast/router.py
329faf4 
Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
@barnjamin @ahangsu
Update pyteal/ast/router.py
1acca93 
Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
@ahangsu
Copy link
Contributor

ahangsu commented Oct 21, 2022

oh snap something goes wild, looking into it

ahangsu
ahangsu reviewed Oct 21, 2022
View reviewed changes
pyteal/ast/router.py Outdated Show resolved Hide resolved
ahangsu
ahangsu approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is in a good shape, also requesting a pass from @jasonpaulos

michaeldiamant
michaeldiamant approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barnjamin Thanks for the fix - looks correct to me.

Can address out-of-band to the PR: I'd feel more confident if we can generate arbitrary test examples capturing all BaseTypes.

jasonpaulos
jasonpaulos approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks for fixing this

@barnjamin barnjamin merged commit 88f7b3a into master Oct 21, 2022
@barnjamin barnjamin deleted the txn-many-arg branch October 21, 2022 20:55
@ahangsu ahangsu mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyfloatersu tonyfloatersu tonyfloatersu left review comments

@michaeldiamant michaeldiamant michaeldiamant approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@ahangsu ahangsu ahangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@barnjamin @ahangsu @michaeldiamant @jasonpaulos @tonyfloatersu