Modify constant order for same frequency #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, when compiling with
assembleConstants
enabled, constants referenced with the same frequency would have their order determined by comparing the value of the constant being referenced. This PR takes advantage of Python's stable sorting to maintain the relative order of constants with the same frequency instead of using their value as an arbitrary tiebreaker.This change should make PyTeal's constant assembly identical to the optimized assembly implemented in algorand/go-algorand#2215.